-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-5] Refactor and update heatmap #5704
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5704 +/- ##
==========================================
- Coverage 63.45% 63.43% -0.02%
==========================================
Files 361 361
Lines 22972 22978 +6
Branches 2557 2558 +1
==========================================
Hits 14576 14576
- Misses 8381 8387 +6
Partials 15 15
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for going through all of these so thoroughly/carefully, and making big improvements on top of it!
* Extract slice and formData * Define data shape * update style * organize imports * fix heatmap axis labels * add new line * adjust indent (cherry picked from commit fcf2c75)
* Extract slice and formData * Define data shape * update style * organize imports * fix heatmap axis labels * add new line * adjust indent
* Extract slice and formData * Define data shape * update style * organize imports * fix heatmap axis labels * add new line * adjust indent
slice
andformData
according to [SIP-5]@williaster @conglei